Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38138: Fix memory leak introduced by interned strings #16053

Merged
merged 1 commit into from Sep 12, 2019
Merged

bpo-38138: Fix memory leak introduced by interned strings #16053

merged 1 commit into from Sep 12, 2019

Conversation

DinoV
Copy link
Contributor

@DinoV DinoV commented Sep 12, 2019 •
edited by miss-islington

Interned string needs to be decref'd

https://bugs.python.org/issue38138

Automerge-Triggered-By: @matrixise

matrixise
matrixise approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@matrixise matrixise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked on my laptop, I have no leak with your patch

./python -m test test_importlib -R 3:3

Thank you

@miss-islington
Copy link
Contributor

@DinoV: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 8d88e8c into python:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matrixise matrixise matrixise approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@DinoV @miss-islington @matrixise @the-knights-who-say-ni @bedevere-bot