Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-29986: Delete tip to raise TypeError from tp_richcompare. #16095

Merged
merged 1 commit into from Sep 13, 2019
Merged

bpo-29986: Delete tip to raise TypeError from tp_richcompare. #16095

merged 1 commit into from Sep 13, 2019

Conversation

JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented Sep 13, 2019 •
edited by bedevere-bot

This is just a rebase of #987 on top of master, so it can be merged.

https://bugs.python.org/issue29986

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Sep 13, 2019
@JulienPalard JulienPalard mentioned this pull request Sep 13, 2019
Closed
@JulienPalard JulienPalard merged commit 375a3e2 into python:master Sep 13, 2019
@JulienPalard JulienPalard deleted the tp-richcomare branch September 13, 2019 13:07
@miss-islington
Copy link
Contributor

Thanks @JulienPalard for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2019
@JulienPalard @miss-islington
bpo-29986: Doc: Delete tip to raise TypeError from tp_richcompare. (p…
c08dc7c 
…ythonGH-16095)

(cherry picked from commit 375a3e2)

Co-authored-by: Julien Palard <julien@palard.fr>
@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Sep 13, 2019
@bedevere-bot
Copy link

GH-16097 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Contributor

Sorry, @JulienPalard, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 375a3e2bdbeb4dce69aba4b5bc90f55fe27e81b4 3.7

@JulienPalard JulienPalard removed their assignment Sep 13, 2019
miss-islington added a commit that referenced this pull request Sep 13, 2019
@miss-islington @JulienPalard
bpo-29986: Doc: Delete tip to raise TypeError from tp_richcompare. (G…
4556b1d 
…H-16095)

(cherry picked from commit 375a3e2)

Co-authored-by: Julien Palard <julien@palard.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JulienPalard @miss-islington @bedevere-bot @the-knights-who-say-ni @ssbr