Updated incorrect level-setting code to use setLevel(). #16325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsajip
added
type-bug
|
Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
I'm having trouble backporting to |
|
GH-16326 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 22, 2019
(cherry picked from commit 1d094af) Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
vsajip
added
needs backport to 3.8
|
Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 22, 2019
(cherry picked from commit 1d094af) Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
|
GH-16327 is a backport of this pull request to the 3.8 branch. |
vsajip
pushed a commit
that referenced
this pull request
Sep 22, 2019
vsajip
pushed a commit
that referenced
this pull request
Sep 22, 2019
yarikoptic
added a commit
to yarikoptic/datalad
that referenced
this pull request
Dec 16, 2019
Apparently .level is not even a property and I guess starting from 3.7 treatment has changed, or broke. May be smth like (scheduled for 3.9 with backport requests for 3.8) python/cpython#16325 was intended to fix it, I did not investigate deep enough -- just fixed the issue we started to experience (Closes datalad#3545)
yarikoptic
added a commit
to yarikoptic/ReproNim
that referenced
this pull request
Oct 15, 2020
Apparently .level is not even a property and I guess starting from 3.7 treatment has changed, or broke. May be smth like (scheduled for 3.9 with backport requests for 3.8) python/cpython#16325 was intended to fix it, I did not investigate deep enough -- just fixed the issue we started to experience (Closes #3545) CPed from DataLad: https://patch-diff.githubusercontent.com/raw/datalad/datalad/pull/3935.patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.