bpo-35182: fix communicate() crash after child closes its pipes #17020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…7020) When communicate() is called in a loop, it crashes when the child process has already closed any piped standard stream, but still continues to be running
Codecov Report
@@ Coverage Diff @@
## master #17020 +/- ##
=========================================
Coverage ? 82.13%
=========================================
Files ? 1951
Lines ? 580578
Branches ? 44252
=========================================
Hits ? 476847
Misses ? 94109
Partials ? 9622
Continue to review full report at Codecov.
|
|
please port it to 3.7 & 3.8 |
|
Hi, I'm hitting this issue in production. Is there anything I could do to help get this merged? |
|
can you resolve the test_subprocess.py merge conflict? |
|
that's ok, let's proceed with your PR |
|
thanks! other PR merged. :) |
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
…onGH-17020) (pythonGH-18117) When communicate() is called in a loop, it crashes when the child process has already closed any piped standard stream, but still continues to be running Co-authored-by: Andriy Maletsky <andriy.maletsky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When communicate() is called in a loop, it crashes when the child process has already closed any piped standard stream, but still continues to be running. The fix is trivial.
https://bugs.python.org/issue35182