Update _threadmodule.c #17116
Closed
Update _threadmodule.c #17116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuNum>1 ,rlock_count<0
|
Thanks for the PR @toywei! Since these changes touch live code, though, this should have a BPO issue and a NEWS entry. |
brandtbucher
requested changes
Nov 12, 2019
| @@ -347,7 +347,7 @@ rlock_release(rlockobject *self, PyObject *Py_UNUSED(ignored)) | |||
| { | |||
| unsigned long tid = PyThread_get_thread_ident(); | |||
|
|
|||
| if (self->rlock_count == 0 || self->rlock_owner != tid) { | |||
| if (self->rlock_count <= 0 || self->rlock_owner != tid) { | |||
There was a problem hiding this comment.
rlock_count is an unsigned long here, so I can't see why this change would be necessary.
|
I'm going to close this as the code review and the request for a bpo ticket hasn't been addressed. This can be reopened if the original author is interested in addressing the review. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpuNum>1 ,rlock_count<0