bpo-38960: DTrace build fix for FreeBSD. #17451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allowing passing an extra flag as it need to define the arch size. - casting some probe's arguments.
ghost
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
ghost
changed the title
brettcannon
reviewed
Dec 3, 2019
| @@ -0,0 +1 @@ | |||
| DTrace build fix aimed for FreeBSD | |||
There was a problem hiding this comment.
Suggested change
| DTrace build fix aimed for FreeBSD | |
| Fix DTrace build issues on FreeBSD. Patch by David Carlier. |
brettcannon
requested review from
brettcannon
and removed request for
brettcannon
encukou
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
encukou
approved these changes
Jan 28, 2020
|
The PPC64 Fedora buildbot failure was unrelated. |
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
DTrace build fix for FreeBSD. - allowing passing an extra flag as it need to define the arch size. - casting some probe's arguments.
|
See also https://bugs.python.org/issue39761 that started to happen since this PR was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue38960
Automerge-Triggered-By: @encukou