New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-38991: Remove test.support.strip_python_stderr() #17490
Conversation
test.support: run_python_until_end(), assert_python_ok() and assert_python_failure() functions no longer strip whitespaces from stderr.
@gpshead, @pablogsal, @ezio-melotti: What do you think of removing the function and modify script_helper functions to no longer strip whitespaces? If plan to do both changes anyway :-) |
This looks good assuming we don't want the testsuite to pass when |
It seems like the test suite pass with this change and -X showrefcount: test.support.args_from_interpreter_flags() doesn't inherit -X showrefcount to child processes. Or do you think that test.support.args_from_interpreter_flags() should be modified to inherit -X showrefcount? I never used -X showrefcount. I'm not sure if anyone uses it. -- Multiple tests fail if I modify Python to force showrefcount:
|
sounds like we're all good then, lets not inherit -X showrefcount, that'll just cause headaches :) |
Thanks for your review @gpshead and @serhiy-storchaka ;-) |
test.support: run_python_until_end(), assert_python_ok() and assert_python_failure() functions no longer strip whitespaces from stderr.
test.support: run_python_until_end(), assert_python_ok() and
assert_python_failure() functions no longer strip whitespaces from
stderr.
https://bugs.python.org/issue38991