Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38588: Optimize list comparison. #17766

Merged
merged 1 commit into from Dec 31, 2019
Merged

bpo-38588: Optimize list comparison. #17766

merged 1 commit into from Dec 31, 2019

Conversation

methane
Copy link
Member

@methane methane commented Dec 31, 2019 •
edited by bedevere-bot

Mitigate performance regression of the list comparison caused by
2d5bf56.

https://bugs.python.org/issue38588

@methane
bpo-38588: Optimize list comparison.
84722af 
Mitigate performance regression of the list comparison caused by
2d5bf56.
@pablogsal
Copy link
Member

pablogsal commented Dec 31, 2019 •
edited

Wouldn't this affect this case? [float("nan")] == [float("nan")]

Edit: Sorry, I checked and it should not affect it.

pablogsal
pablogsal approved these changes Dec 31, 2019
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the analysis and the quick fix Inada-san.

And apologies for missing the comment in bpo.

corona10
corona10 approved these changes Dec 31, 2019
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the analysis @methane

@methane methane merged commit dfef986 into python:master Dec 31, 2019
@methane methane deleted the list-cmp-opt branch December 31, 2019 01:58
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@methane @shihai1991
bpo-38588: Optimize list comparison. (pythonGH-17766)
6c75c55 
Mitigate performance regression of the list comparison caused by 2d5bf56.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@methane @pablogsal @corona10 @the-knights-who-say-ni @bedevere-bot