Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39195: Check earlier if pattern is compiled in _compile #17799

Closed
wants to merge 1 commit into from

Conversation

Recursing
Copy link
Contributor

@Recursing Recursing commented Jan 2, 2020

Improve performance by checking for already compiled patterns before checking for the type of flags and accessing the module cache

https://bugs.python.org/issue39195

Improve performance by checking for already compiled patterns before checking for the type of flags and accessing the module cache
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Recursing

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@Recursing
Copy link
Contributor Author

Recursing commented Jan 2, 2020

I think I had already signed the agreement, signed it again anyway

Closing PR, see discussion on bpo

@Recursing Recursing closed this Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants