Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-68525: Implement email.message.Message.__repr__() #18127

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

gh-68525: Implement email.message.Message.__repr__() #18127

wants to merge 2 commits into from

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Jan 22, 2020 •
edited by bedevere-app bot

@ZackerySpytz ZackerySpytz requested a review from a team as a code owner January 22, 2020 20:21
bitdancer
bitdancer requested changes Jan 22, 2020
View reviewed changes
Lib/email/message.py
@@ -134,6 +134,10 @@ def __str__(self):
"""
return self.as_string()

def __repr__(self):
return f"{self.__class__.__name__} with {len(self._headers)} " \
f"headers and Content-Type {self._default_type}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't match the suggestion in the issue. self._default_type is also wrong, since that's just the default, not the actual content-type of the message (which comes from the headers).

What exactly goes in the repr should be discussed further in the issue.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@csabella
Copy link
Contributor

@ZackerySpytz please address the code review. Thank you!

@cool-RR cool-RR mannequin mentioned this pull request Jan 5, 2024
Open
@erlend-aasland erlend-aasland changed the title bpo-24337: Implement email.message.Message.__repr__() gh-68525: Implement email.message.Message.__repr__() Jan 5, 2024
@erlend-aasland erlend-aasland marked this pull request as draft January 5, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitdancer bitdancer bitdancer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ZackerySpytz @bedevere-bot @csabella @bitdancer @the-knights-who-say-ni @ezio-melotti @erlend-aasland