Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39440: Speed up sum() by using in place add #18156

Closed
wants to merge 2 commits into from

Conversation

ammaraskar
Copy link
Member

@ammaraskar ammaraskar commented Jan 24, 2020

Ed asked me to contribute this on their behalf as they did not want to go through the CLA process.

https://bugs.python.org/issue39440

Co-authored-by: Ed Kellett <e@kellett.im>
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself looks fine, but this is a breaking semantic change that has been discussed before. See my comment on the BPO issue!

@brandtbucher brandtbucher added the performance Performance or resource usage label Jan 24, 2020
@ammaraskar
Copy link
Member Author

Thank you for the insight Brandt! Ed has closed the issue so I'm closing this off as well.

@ammaraskar ammaraskar closed this Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review performance Performance or resource usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants