bpo-39524: Fixed doc-string in ast._pad_whitespace #18340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Codecov Report
@@ Coverage Diff @@
## master #18340 +/- ##
==========================================
- Coverage 82.20% 82.11% -0.09%
==========================================
Files 1957 1954 -3
Lines 588894 583559 -5335
Branches 44382 44429 +47
==========================================
- Hits 484072 479209 -4863
+ Misses 95175 94703 -472
Partials 9647 9647
Continue to review full report at Codecov.
|
Lib/ast.py
Outdated
| @@ -302,7 +302,7 @@ def _splitlines_no_ff(source): | |||
|
|
|||
|
|
|||
| def _pad_whitespace(source): | |||
| """Replace all chars except '\f\t' in a line with spaces.""" | |||
| """Replace all chars except '\\f\\t' in a line with spaces.""" | |||
There was a problem hiding this comment.
LGTM, but I prefer to use a raw string literal.
There was a problem hiding this comment.
I have no absolute preference. You can change it if you consider raw string as more suitable.
There was a problem hiding this comment.
@mpheath, thank you for your contribution to CPython and for your interest in improving the language and the documentation. Serhiy's suggestion was asking if you could change it to a raw string in your PR and then he'll merge the change.
There was a problem hiding this comment.
Changed to raw string literal.
|
Signing the CLA is not required for such trivial change. |
serhiy-storchaka
approved these changes
Feb 13, 2020
|
Thanks @mpheath for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Sorry @mpheath and @serhiy-storchaka, I had trouble checking out the |
|
GH-22857 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
that referenced
this pull request
Oct 21, 2020
|
|
|
|
|
colesbury
referenced
this pull request
in colesbury/nogil
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escape sequences in doc string of ast._pad_whitespace
https://bugs.python.org/issue39524