Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39417: Fix broken link to guide to building venvs #18432

Merged
merged 1 commit into from Feb 10, 2020

Conversation

@j9ac9k
Copy link
Contributor

j9ac9k commented Feb 10, 2020

Fix broken link in python packaging user guide

[bpo-39417](https://bugs.python.org/issue39417): Fix broken link to "See also: Python Packaging User Guide: Creating and using virtual environments"

https://bugs.python.org/issue39417

@the-knights-who-say-ni

This comment has been minimized.

Copy link

the-knights-who-say-ni commented Feb 10, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@j9ac9k

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@j9ac9k

This comment has been minimized.

Copy link
Contributor Author

j9ac9k commented Feb 10, 2020

I have signed the CLA and am waiting the 1 US Business Day before checking the status on the check-python-cla website

@ammaraskar

This comment has been minimized.

Copy link
Member

ammaraskar commented Feb 10, 2020

Thanks for your contribution @j9ac9k! Could you put the bugs.python.org issue number in the commit message and PR title as shown here: https://devguide.python.org/pullrequest/#making-good-commits

@j9ac9k j9ac9k force-pushed the j9ac9k:bpo-39417 branch 2 times, most recently from ebd0021 to 923af66 Feb 10, 2020
@j9ac9k j9ac9k force-pushed the j9ac9k:bpo-39417 branch from 923af66 to dfff0bd Feb 10, 2020
@j9ac9k j9ac9k changed the title Fix broken link to guide to building venvs bpo- 39417: Fix broken link to guide to building venvs Feb 10, 2020
@j9ac9k j9ac9k changed the title bpo- 39417: Fix broken link to guide to building venvs bpo-39417: Fix broken link to guide to building venvs Feb 10, 2020
@j9ac9k

This comment has been minimized.

Copy link
Contributor Author

j9ac9k commented Feb 10, 2020

sorry for the multiple forced commits, I got a bit configured in the docs with what the format should be of the git commit msg; git commit msg should now be correct.

Copy link
Member

ammaraskar left a comment

LGTM once CLA is approved.

@bonitobird

This comment has been minimized.

Copy link

bonitobird commented Feb 10, 2020

At PyCascades Sprint, this is good to go. @willingc Please review.

@willingc willingc merged commit c4a65ed into python:master Feb 10, 2020
5 checks passed
5 checks passed
Docs
Details
Azure Pipelines PR #20200210.16 succeeded
Details
bedevere/issue-number Issue number 39417 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
petdance added a commit to petdance/cpython that referenced this pull request Feb 11, 2020
@j9ac9k j9ac9k deleted the j9ac9k:bpo-39417 branch Feb 11, 2020
opavlyuk pushed a commit to opavlyuk/cpython that referenced this pull request Feb 12, 2020
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
petdance added a commit to petdance/cpython that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.