Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39417: Fix broken link to guide to building venvs #18432

Merged
merged 1 commit into from Feb 10, 2020
Merged

bpo-39417: Fix broken link to guide to building venvs #18432

merged 1 commit into from Feb 10, 2020

Conversation

j9ac9k
Copy link
Contributor

@j9ac9k j9ac9k commented Feb 10, 2020

Fix broken link in python packaging user guide

[bpo-39417](https://bugs.python.org/issue39417): Fix broken link to "See also: Python Packaging User Guide: Creating and using virtual environments"

https://bugs.python.org/issue39417

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@j9ac9k

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 10, 2020
@j9ac9k
Copy link
Contributor Author

j9ac9k commented Feb 10, 2020

I have signed the CLA and am waiting the 1 US Business Day before checking the status on the check-python-cla website

@ammaraskar
Copy link
Member

ammaraskar commented Feb 10, 2020

Thanks for your contribution @j9ac9k! Could you put the bugs.python.org issue number in the commit message and PR title as shown here: https://devguide.python.org/pullrequest/#making-good-commits

@j9ac9k j9ac9k changed the title Fix broken link to guide to building venvs bpo- 39417: Fix broken link to guide to building venvs Feb 10, 2020
@j9ac9k j9ac9k changed the title bpo- 39417: Fix broken link to guide to building venvs bpo-39417: Fix broken link to guide to building venvs Feb 10, 2020
@j9ac9k
Copy link
Contributor Author

j9ac9k commented Feb 10, 2020

sorry for the multiple forced commits, I got a bit configured in the docs with what the format should be of the git commit msg; git commit msg should now be correct.

Copy link
Member

@ammaraskar ammaraskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CLA is approved.

@bonitobird
Copy link

At PyCascades Sprint, this is good to go. @willingc Please review.

@willingc willingc merged commit c4a65ed into python:master Feb 10, 2020
@j9ac9k j9ac9k deleted the bpo-39417 branch February 11, 2020 04:53
@Mariatta Mariatta added the needs backport to 3.8 only security fixes label Jul 7, 2020
@miss-islington
Copy link
Contributor

Thanks @j9ac9k for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Jul 7, 2020
@bedevere-bot
Copy link

GH-21383 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2020
(cherry picked from commit c4a65ed)

Co-authored-by: Ogi Moore <ognyan.moore@jacobs.ucsd.edu>
miss-islington added a commit that referenced this pull request Jul 7, 2020
(cherry picked from commit c4a65ed)

Co-authored-by: Ogi Moore <ognyan.moore@jacobs.ucsd.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants