Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38325: Fix test_winconsoleio #18448

Merged
merged 1 commit into from Feb 10, 2020
Merged

bpo-38325: Fix test_winconsoleio #18448

merged 1 commit into from Feb 10, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Feb 10, 2020 •
edited by bedevere-bot

Skip tests on non-BMP characters of test_winconsoleio.

https://bugs.python.org/issue38325

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Feb 10, 2020
@vstinner
bpo-38325: Skip non-BMP tests of test_winconsoleio
3061a55 
Skip tests on non-BMP characters of test_winconsoleio.
@vstinner
Copy link
Member Author

Without this PR, test_winconsoleio still fails as described in https://bugs.python.org/issue38325

With this PR, test_winconsoleio pass successfully.

@vstinner vstinner merged commit 038770e into python:master Feb 10, 2020
@vstinner vstinner deleted the test_winconsoleio branch February 10, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot