Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39379:sys.path[0] is already absolute path #18561

Merged
merged 5 commits into from
Feb 29, 2020
Merged

bpo-39379:sys.path[0] is already absolute path #18561

merged 5 commits into from
Feb 29, 2020

Conversation

ananthan-123
Copy link
Contributor

@ananthan-123 ananthan-123 commented Feb 19, 2020 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 19, 2020
tirkarthi
tirkarthi reviewed Feb 19, 2020
View reviewed changes
Doc/whatsnew/3.9.rst Outdated Show resolved Hide resolved
@tirkarthi
Copy link
Member

NEWS entry is not needed for this change IMO.

@ananthan-123
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

: please review the changes made to this pull request.

@aeros
Copy link
Contributor

aeros commented Feb 21, 2020

@tirkarthi

NEWS entry is not needed for this change IMO.

Agreed, I'll add a skip-news label.

aeros
aeros reviewed Feb 21, 2020
View reviewed changes
Copy link
Contributor

@aeros aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, other than a minor point on grammar that was present in the original entry. Not critical, but I think we should address it.

Also, I think this should receive approval from @vstinner prior to merging, just to be sure (since he originally wrote the patch for this entry).

Doc/whatsnew/3.9.rst Outdated Show resolved Hide resolved
@ananthan-123 @aeros
Update Doc/whatsnew/3.9.rst
ee5e034 
Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
@ananthan-123 ananthan-123 requested review from gvanrossum and removed request for tirkarthi and corona10 February 24, 2020 11:29
@gvanrossum gvanrossum removed their request for review February 24, 2020 16:13
@tirkarthi tirkarthi merged commit 1f0cd3c into python:master Feb 29, 2020
@tirkarthi
Copy link
Member

I have merged the PR since it's minor. I have left the issue open due to question at https://bugs.python.org/issue39379#msg360333 , Thanks for the patch and review.

@sthagen sthagen mentioned this pull request Feb 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi left review comments

@aeros aeros aeros left review comments

@gvanrossum gvanrossum gvanrossum approved these changes

@vstinner vstinner Awaiting requested review from vstinner

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ananthan-123 @tirkarthi @bedevere-bot @aeros @gvanrossum @the-knights-who-say-ni