Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38691: Ignore pythoncaseok tests #18627

Merged
merged 7 commits into from Mar 9, 2020

Conversation

idomic
Copy link
Contributor

@idomic idomic commented Feb 23, 2020

bpo-38691 Ignore pythoncaseok tests

[3.9] bpo-38691 Added a switch to ignore PYTHONCASEOK when -E or -I flags passed (GH-18627)

https://bugs.python.org/issue38691

@vstinner
Copy link
Member

Tests / macOS (pull_request) Failing after 14m

That's why the PR #18314 was reverted: https://bugs.python.org/issue38691#msg362202

@idomic
Copy link
Contributor Author

idomic commented Mar 1, 2020

@vstinner ready for review

@codecov
Copy link

codecov bot commented Mar 1, 2020

Codecov Report

Merging #18627 into master will increase coverage by 1.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18627       +/-   ##
===========================================
+ Coverage   82.13%   83.22%    +1.09%     
===========================================
  Files        1955     1571      -384     
  Lines      584601   415387   -169214     
  Branches    44484    44488        +4     
===========================================
- Hits       480156   345709   -134447     
+ Misses      94793    60029    -34764     
+ Partials     9652     9649        -3     
Impacted Files Coverage Δ
Lib/test/test_poll.py 89.20% <0.00%> (-1.14%) ⬇️
Lib/ast.py 74.33% <0.00%> (-0.85%) ⬇️
Lib/random.py 88.12% <0.00%> (-0.28%) ⬇️
Lib/asyncio/base_events.py 81.86% <0.00%> (-0.10%) ⬇️
Lib/functools.py 95.46% <0.00%> (ø) ⬆️
Modules/cjkcodecs/multibytecodec.c
Objects/accu.c
Modules/clinic/_hashopenssl.c.h
Modules/sha512module.c
Modules/signalmodule.c
... and 388 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b0d29f...d9db68a. Read the comment docs.

@@ -0,0 +1 @@
Updated :meth:`importlib._bootstrap_external._make_relax_case` to ignore :envvar:`PYTHONCASEOK` when -E or -I flags are used.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to avoid mentioning a private module (_bootstrap_external) in a public Changelog entry. Reuse the text that you wrote above:

  The :mod:`importlib` module now ignores the :envvar:`PYTHONCASEOK`
  environment variable when the :option:`-E` or :option:`-I` command line
  options are being used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vstinner Fixed.

@vstinner vstinner merged commit fc72ab6 into python:master Mar 9, 2020
@vstinner
Copy link
Member

vstinner commented Mar 9, 2020

Thanks, merged.

@idomic idomic deleted the bpo-38691-pythoncaseok branch March 15, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants