Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-37708: random.choice no longer causes errors #18694

Closed
wants to merge 1 commit into from

Conversation

Gaming32
Copy link

@Gaming32 Gaming32 commented Feb 28, 2020

random.choice (and random.Random.choice) no longer causes errors if seq is not subscriptable
I realize that this may be rejected, but I have now experienced two locations where this issue has bothered me. The modification uses an optimized method to handle non-subscriptable objects.

https://bugs.python.org/issue37708

random.choice (and random.Random.choice) no longer causes errors if seq is not index-able
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Gaming32

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@Gaming32 Gaming32 changed the title bpo-37708: random.choice no longer causes errors Lex Flagel-37708: random.choice no longer causes errors Feb 28, 2020
@Gaming32 Gaming32 changed the title Lex Flagel-37708: random.choice no longer causes errors bpo-37708: random.choice no longer causes errors Feb 28, 2020
@rhettinger rhettinger closed this Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants