Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-12915: Fix test to recognize when filesystem encoding cannot encode Unicode string #18720

Merged
merged 3 commits into from Mar 3, 2020

Conversation

aixtools
Copy link
Contributor

@aixtools aixtools commented Mar 1, 2020

When filesystem encoding cannot encode the Unicode string used for a filename

continue testing with the next example.

https://bugs.python.org/issue12915

…filename

continue testing with the next example.
@codecov
Copy link

codecov bot commented Mar 1, 2020

Codecov Report

Merging #18720 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18720      +/-   ##
==========================================
- Coverage   82.13%   82.13%   -0.01%     
==========================================
  Files        1955     1955              
  Lines      584601   584742     +141     
  Branches    44484    44488       +4     
==========================================
+ Hits       480156   480268     +112     
- Misses      94793    94825      +32     
+ Partials     9652     9649       -3     
Impacted Files Coverage Δ
Lib/asynchat.py 80.00% <0.00%> (-2.07%) ⬇️
Modules/binascii.c 85.86% <0.00%> (-0.91%) ⬇️
Lib/ast.py 74.33% <0.00%> (-0.85%) ⬇️
Lib/test/test_poplib.py 92.80% <0.00%> (-0.80%) ⬇️
Lib/_weakrefset.py 59.18% <0.00%> (-0.69%) ⬇️
Lib/random.py 88.12% <0.00%> (-0.28%) ⬇️
Modules/expat/xmlparse.c 61.69% <0.00%> (-0.12%) ⬇️
Lib/asyncio/base_events.py 81.86% <0.00%> (-0.10%) ⬇️
Lib/functools.py 95.46% <0.00%> (ø) ⬆️
Objects/listobject.c 90.77% <0.00%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b0d29f...976d7d4. Read the comment docs.

@vstinner vstinner merged commit e0acec1 into python:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants