Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38597: Never statically link extension initialization code on Windows #18724

Merged
merged 1 commit into from
Mar 3, 2020
Merged

bpo-38597: Never statically link extension initialization code on Windows #18724

merged 1 commit into from
Mar 3, 2020

Conversation

zooba
Copy link
Member

@zooba zooba commented Mar 1, 2020 •
edited by bedevere-bot
Loading

@zooba zooba added type-bug An unexpected behavior, bug, or error OS-windows needs backport to 3.7 needs backport to 3.8 only security fixes labels Mar 1, 2020
@zooba zooba requested a review from a team as a code owner March 1, 2020 15:05
@codecov
Copy link

codecov bot commented Mar 1, 2020

Codecov Report

Merging #18724 into master will increase coverage by 1.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18724       +/-   ##
===========================================
+ Coverage   82.13%   83.23%    +1.09%     
===========================================
  Files        1955     1571      -384     
  Lines      584601   415210   -169391     
  Branches    44484    44484               
===========================================
- Hits       480156   345590   -134566     
+ Misses      94793    59972    -34821     
+ Partials     9652     9648        -4
Impacted Files Coverage Δ
Lib/test/test_random.py 96.78% <0.00%> (-0.31%) ⬇️
Lib/random.py 88.12% <0.00%> (-0.28%) ⬇️
Lib/asyncio/base_events.py 81.86% <0.00%> (-0.10%) ⬇️
Lib/idlelib/squeezer.py 93.23% <0.00%> (ø) ⬆️
Python/formatter_unicode.c
Objects/interpreteridobject.c
Python/clinic/bltinmodule.c.h
Modules/cjkcodecs/_codecs_hk.c
Modules/clinic/_tracemalloc.c.h
Objects/listobject.c
... and 383 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b0d29f...b322495. Read the comment docs.

zware
zware reviewed Mar 2, 2020
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks basically fine to me, but I'm not familiar enough to really say yay or nay. Paging @eryksun :)

Lib/distutils/_msvccompiler.py Show resolved Hide resolved
@zooba zooba merged commit ce3a498 into python:master Mar 3, 2020
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@zooba zooba deleted the bpo-38597 branch March 3, 2020 00:04
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2020
@zooba @miss-islington
bpo-38597: Never statically link extension initialization code on Win…
7ce2f60 
…dows (pythonGH-18724)

(cherry picked from commit ce3a498)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

GH-18758 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Mar 3, 2020
@miss-islington
Copy link
Contributor

Sorry, @zooba, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ce3a4984089b8e0ce5422ca32d75ad057b008074 3.7

zooba added a commit to zooba/cpython that referenced this pull request Mar 3, 2020
@zooba
bpo-38597: Never statically link extension initialization code on Win…
42100b3 
…dows (pythonGH-18724)
@bedevere-bot
Copy link

GH-18759 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit that referenced this pull request Mar 3, 2020
@zooba
[3.7] bpo-38597: Never statically link extension initialization code …
8a5f7ad 
…on Windows (GH-18724) (GH-18759)

Automerge-Triggered-By: @zooba
miss-islington added a commit that referenced this pull request Mar 3, 2020
@miss-islington @zooba
bpo-38597: Never statically link extension initialization code on Win…
0d20364 
…dows (GH-18724)

(cherry picked from commit ce3a498)

Co-authored-by: Steve Dower <steve.dower@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware left review comments

Assignees

@zooba zooba

Labels
OS-windows type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zooba @miss-islington @bedevere-bot @zware @the-knights-who-say-ni