bpo-39573: Use Py_IS_TYPE for type checking #18789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Mar 5, 2020
| return ob->ob_type == type; | ||
| } | ||
| #define Py_IS_TYPE(ob, type) _Py_IS_TYPE(_PyObject_CAST(ob), type) |
There was a problem hiding this comment.
I would prefer to have a new private _PyObject_CAST_CONST() macro rather than casting directly.
I prefer macros because maybe tomorrow we might be able to check if the pointer is valid PyObject in debug mode. Maybe using _PyObject_CheckConsistency().
Would you mind to move these changes (add the macro and modify Py_IS_TYPE to use const) into a separated PR?
There was a problem hiding this comment.
Sure, I'll make two separate PRs.
|
I merged PR #18809. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes up the conversions to using Py_IS_TYPE for checking object types.
It also updates Py_IS_TYPE(ob, type) to be able to take a const objects and a const type.
https://bugs.python.org/issue39573