Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40185: Refactor typing.NamedTuple #19371

Merged
merged 3 commits into from
Apr 8, 2020
Merged

bpo-40185: Refactor typing.NamedTuple #19371

merged 3 commits into from
Apr 8, 2020

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Apr 4, 2020 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added type-feature A feature request or enhancement skip news labels Apr 4, 2020
ilevkivskyi
ilevkivskyi approved these changes Apr 4, 2020
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change, because people sometimes erroneously percept NamedTuple as a "normal" class. I would however double-check with Guido if he is also OK with this.

Lib/test/test_typing.py Outdated
pass
with self.assertRaises(TypeError):
class X(NamedTuple, A):
x: int
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a bad merge/rebase, you already added this test in a different PR.

gvanrossum
gvanrossum approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A work of art!

@serhiy-storchaka serhiy-storchaka merged commit a2ec069 into python:master Apr 8, 2020
@serhiy-storchaka serhiy-storchaka deleted the refactor-typing-namedtuple branch April 8, 2020 07:59
@serhiy-storchaka
Copy link
Member Author

Thanks. 😊

juliusgeo added a commit to juliusgeo/cpython that referenced this pull request Mar 4, 2022
@juliusgeo
Revert "bpo-40185: Refactor typing.NamedTuple (pythonGH-19371)"
03f1573 
This reverts commit a2ec069.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
skip news type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@serhiy-storchaka @gvanrossum @ilevkivskyi @the-knights-who-say-ni @bedevere-bot