Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40270: Enable json extension in windows sqlite extension #19528

Merged
merged 2 commits into from
Apr 15, 2020
Merged

bpo-40270: Enable json extension in windows sqlite extension #19528

merged 2 commits into from
Apr 15, 2020

Conversation

ammaraskar
Copy link
Member

@ammaraskar ammaraskar commented Apr 14, 2020 •
edited
Loading

Here's the change in the size of the compiled sqlite library:

Before:

λ du -h win32\sqlite3.dll
1008K   win32\sqlite3.dll

After:

1.1M    win32\sqlite3.dll

https://bugs.python.org/issue40270

@ammaraskar ammaraskar requested a review from a team as a code owner April 14, 2020 23:25
@ammaraskar ammaraskar requested review from zooba and zware April 14, 2020 23:26
zware
zware reviewed Apr 15, 2020
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit in the NEWS wording, but otherwise LGTM.

Misc/NEWS.d/next/Library/2020-04-14-16-18-49.bpo-40270.XVJzeG.rst Outdated Show resolved Hide resolved
@zware zware merged commit 58d6f2e into python:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware approved these changes

@zooba zooba Awaiting requested review from zooba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ammaraskar @zware @the-knights-who-say-ni @bedevere-bot