Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40419: timeit CLI docs now mention 1,2,5,10,... trials instead of powers of 10 #19752

Merged
merged 1 commit into from May 2, 2020

Conversation

sjvrijn
Copy link
Contributor

@sjvrijn sjvrijn commented Apr 28, 2020

Docs updated both in the Lib/timeit.py and Doc/library/timeit.rst files

https://bugs.python.org/issue40419

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@sjvrijn

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Contributor

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sjvrijn, thanks for fixing the docs. Please sign the CLA, it may not be necessary for this change but you will need it if you want to contribute more significant changes in the future :)

@sjvrijn
Copy link
Contributor Author

sjvrijn commented May 1, 2020

Hi @remilapeyre, the CLA has been signed. Is there anything else I forgot?

@remilapeyre
Copy link
Contributor

Hi @sjvrijn, everything's good then 👍 .

Now a core developer will make a second round of review and will either merge your PR or ask for some changes. There is a lot of PRs to review so it may take some time thought.

Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@serhiy-storchaka
Copy link
Member

👍 Thank you for your report and PR Sander!

@serhiy-storchaka serhiy-storchaka added needs backport to 3.7 needs backport to 3.8 only security fixes docs Documentation in the Doc dir labels May 2, 2020
@serhiy-storchaka serhiy-storchaka merged commit 7663523 into python:master May 2, 2020
@miss-islington
Copy link
Contributor

Thanks @sjvrijn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 2, 2020
… powers of 10 (pythonGH-19752)

(cherry picked from commit 7663523)

Co-authored-by: Sander <svr003@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label May 2, 2020
@bedevere-bot
Copy link

GH-19863 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 2, 2020
… powers of 10 (pythonGH-19752)

(cherry picked from commit 7663523)

Co-authored-by: Sander <svr003@gmail.com>
@bedevere-bot
Copy link

GH-19864 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request May 2, 2020
… powers of 10 (GH-19752)

(cherry picked from commit 7663523)

Co-authored-by: Sander <svr003@gmail.com>
miss-islington added a commit that referenced this pull request May 2, 2020
… powers of 10 (GH-19752)

(cherry picked from commit 7663523)

Co-authored-by: Sander <svr003@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants