New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-40419: timeit CLI docs now mention 1,2,5,10,... trials instead of powers of 10 #19752
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sjvrijn, thanks for fixing the docs. Please sign the CLA, it may not be necessary for this change but you will need it if you want to contribute more significant changes in the future :)
Hi @remilapeyre, the CLA has been signed. Is there anything else I forgot? |
Hi @sjvrijn, everything's good then 👍 . Now a core developer will make a second round of review and will either merge your PR or ask for some changes. There is a lot of PRs to review so it may take some time thought. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
👍 Thank you for your report and PR Sander! |
Thanks @sjvrijn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
… powers of 10 (pythonGH-19752) (cherry picked from commit 7663523) Co-authored-by: Sander <svr003@gmail.com>
GH-19863 is a backport of this pull request to the 3.8 branch. |
… powers of 10 (pythonGH-19752) (cherry picked from commit 7663523) Co-authored-by: Sander <svr003@gmail.com>
GH-19864 is a backport of this pull request to the 3.7 branch. |
Docs updated both in the
Lib/timeit.py
andDoc/library/timeit.rst
fileshttps://bugs.python.org/issue40419