Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40421: Add PyFrame_GetBack() function #19765

Merged
merged 1 commit into from Apr 29, 2020
Merged

bpo-40421: Add PyFrame_GetBack() function #19765

merged 1 commit into from Apr 29, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Apr 28, 2020

New PyFrame_GetBack() function: return a borrowed reference to the
frame next outer frame.

Replace frame->f_back with PyFrame_GetBack(frame) in most code but
frameobject.c, ceval.c and genobject.c.

https://bugs.python.org/issue40421

@vstinner
Copy link
Member Author

New PyFrame_GetBack() function: return a borrowed reference to the frame next outer frame.

That's wrong: it must return a strong reference: https://bugs.python.org/issue40429

New PyFrame_GetBack() function: get the frame next outer frame.

Replace frame->f_back with PyFrame_GetBack(frame) in most code but
frameobject.c, ceval.c and genobject.c.
@vstinner
Copy link
Member Author

That's wrong: it must return a strong reference: https://bugs.python.org/issue40429

I updated my PR. The function now returns a strong reference.

@vstinner vstinner merged commit 7036477 into python:master Apr 29, 2020
@vstinner vstinner deleted the frame_getback branch April 29, 2020 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants