Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-78612: Docs does not eval allows code object as argument #20000

Closed
wants to merge 3 commits into from
Closed

gh-78612: Docs does not eval allows code object as argument #20000

wants to merge 3 commits into from

Conversation

furkanonder
Copy link
Sponsor Contributor

@furkanonder furkanonder commented May 8, 2020 •
edited by bedevere-bot

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 8, 2020
@furkanonder furkanonder changed the title bpo:34431 Docs does not eval allows code object as argument bpo-34431: Docs does not eval allows code object as argument May 8, 2020
@furkanonder
Copy link
Sponsor Contributor Author

@berkerpeksag

@berkerpeksag
Copy link
Member

berkerpeksag commented May 8, 2020 •
edited

The proper way to move forward is to ask whether Jonathan is planning to work on bpo-34431 anytime soon (https://bugs.python.org/issue34431#msg333148) If he doesn't reply in a week, then we can continue with your PR.

@furkanonder
Copy link
Sponsor Contributor Author

The proper way to move forward is to ask whether Jonathan is planning to work on bpo-34431 anytime soon (https://bugs.python.org/issue34431#msg333148) If he doesn't reply in a week, then we can continue with your PR.

Hello again,
Did Jonathan reply to you?

@berkerpeksag
Copy link
Member

As the author of the PR, it's your responsibility to communicate with other contributors who had already expressed their intent to create a PR. You can simply leave a comment on the BPO issue saying something like "sorry I missed your comment, are you still planning to work on this?".

@iritkatriel
Copy link
Member

@furkanonder since Jonathan did not reply, you can proceed with this PR.

iritkatriel
iritkatriel reviewed May 20, 2021
View reviewed changes
Doc/library/functions.rst Outdated Show resolved Hide resolved
Doc/library/functions.rst Outdated Show resolved Hide resolved
@slateny
Copy link
Contributor

slateny commented Sep 26, 2022 •
edited

@furkanonder Would you still interested in updating this PR with the suggestions above?

furkanonder and others added 2 commits September 27, 2022 12:08
@furkanonder @iritkatriel
Update Doc/library/functions.rst
8e16f05 
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@furkanonder @iritkatriel
Update Doc/library/functions.rst
3d4297a 
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@furkanonder
Copy link
Sponsor Contributor Author

@iritkatriel I've updated the doc with the changes you suggested. Can you review it again?

@furkanonder furkanonder closed this by deleting the head repository Dec 23, 2022
@furkanonder furkanonder reopened this Dec 23, 2022
@furkanonder furkanonder changed the title bpo-34431: Docs does not eval allows code object as argument gh-78612: Docs does not eval allows code object as argument Aug 6, 2023
@jfine2358 jfine2358 mannequin mentioned this pull request Feb 9, 2024
Closed
@erlend-aasland erlend-aasland mentioned this pull request Feb 9, 2024
Merged
@erlend-aasland
Copy link
Contributor

Superseded by #115212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

Assignees
No one assigned
Labels
awaiting review docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@furkanonder @berkerpeksag @iritkatriel @slateny @erlend-aasland @the-knights-who-say-ni @ezio-melotti @bedevere-bot