Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34556: Document addition of upgrade_deps to venv.create #20135

Merged
merged 1 commit into from May 23, 2020
Merged

bpo-34556: Document addition of upgrade_deps to venv.create #20135

merged 1 commit into from May 23, 2020

Conversation

hauntsaninja
Copy link
Contributor

@hauntsaninja hauntsaninja commented May 16, 2020 •
edited by miss-islington

@hauntsaninja hauntsaninja requested a review from vsajip as a code owner May 16, 2020 21:13
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 16, 2020
@hauntsaninja
Copy link
Contributor Author

We can skip news, since this is just documenting a 3.9 addition

@miss-islington miss-islington merged commit 1cba1c9 into python:master May 23, 2020
@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington
Copy link
Contributor

@hauntsaninja: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.

@hauntsaninja hauntsaninja deleted the venv branch May 23, 2020 22:01
@hauntsaninja
Copy link
Contributor Author

Thanks for reviewing! I'm a little confused by miss-islington's messages. Also, should this be backported to the 3.9 branch?

arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@hauntsaninja @arturoescaip
bpo-34556: Document addition of upgrade_deps to venv.create (pythonGH…
8cd7fd6 
…-20135)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip vsajip approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hauntsaninja @miss-islington @vsajip @the-knights-who-say-ni @bedevere-bot