Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-31904: fix fifo test cases for VxWorks RTOS #20254

Merged
merged 5 commits into from Dec 1, 2020
Merged

bpo-31904: fix fifo test cases for VxWorks RTOS #20254

merged 5 commits into from Dec 1, 2020

Conversation

pxinwr
Copy link
Contributor

@pxinwr pxinwr commented May 20, 2020 •
edited by bedevere-bot

In VxWork RTOS, FIFO must be created under directory "/fifos/". So tuned related test cases accordingly.

https://bugs.python.org/issue31904

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels May 20, 2020
merwok
merwok approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@merwok merwok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK!

@pxinwr
Copy link
Contributor Author

pxinwr commented Aug 10, 2020

This looks OK!

Thanks for your review.

@vstinner
Copy link
Member

Note: The commit 6a273fd skipped FIFO tests in test_pathlib and test_shutil. I'm fine with these skips.

vstinner
vstinner reviewed Nov 30, 2020
View reviewed changes
Lib/test/test_stat.py Show resolved Hide resolved
Lib/test/test_posix.py Show resolved Hide resolved
vstinner
vstinner approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The updated PR is simple enough and is not too intrusive.

If there are more cases tomorrow, it might be worth it to add an helper function to support.os_helper, but I don't think that it's the case now (it's only used in exactly two functions).

@vstinner vstinner merged commit b2d0c66 into python:master Dec 1, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@pxinwr @adorilson
bpo-31904: Fix fifo test cases for VxWorks (pythonGH-20254)
56d84c9
@pxinwr pxinwr deleted the fix-issue-31904-testfifo branch May 7, 2021 07:42
@kuhlenough kuhlenough mannequin mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@merwok merwok merwok approved these changes

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pxinwr @vstinner @merwok @the-knights-who-say-ni @bedevere-bot