Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.6] bpo-30266: support "= None" pattern in AbstractContextManager (… #2054

Merged
merged 1 commit into from
Jun 10, 2017

Conversation

Mariatta
Copy link
Member

GH-1448)

contextlib.AbstractContextManager now supports anti-registration
by setting enter = None or exit = None, following the pattern
introduced in bpo-25958..
(cherry picked from commit 57161aa)

…ythonGH-1448)

contextlib.AbstractContextManager now supports anti-registration
by setting __enter__ = None or __exit__ = None, following the pattern
introduced in bpo-25958..
(cherry picked from commit 57161aa)
@gvanrossum
Copy link
Member

Note the subject of the commit message got truncated and the overflow went into the body.

Also I wonder if it's useful for bpo to send out email when a closed issue is mentioned by a PR. I got pinged on this issue even though it was closed for nearly a year and mentioned, because it was mentioned in the commit message here.

@Mariatta
Copy link
Member Author

Thanks @gvanrossum :)

Seems like this PR was incorrectly linked to an old issue (bpo-25958), it should only be linked to bpo-30266, which is referenced in the title.

I have just opened in up a bug for it here and unlinked this PR from bpo-25958.

Also I wonder if it's useful for bpo to send out email when a closed issue is mentioned by a PR.

Maybe this can be asked to a broader audience, e.g. at core-workflow :)

The text overflow is just in the PR title and description. The actual commit message will not be broken up, and we do get the opportunity to clean up the commit message:
screen shot 2017-06-09 at 6 58 09 pm

@Mariatta Mariatta merged commit 753422f into python:3.6 Jun 10, 2017
@Mariatta Mariatta deleted the backport-57161aa-3.6 branch June 10, 2017 03:36
@Mariatta
Copy link
Member Author

Hmm unlinking it didn't work...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants