bpo-40890: Add mapping property to dict views
#20749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhettinger
approved these changes
Jun 10, 2020
methane
approved these changes
Jun 12, 2020
|
Would you write a What's new entry too? |
rhettinger
approved these changes
Jun 12, 2020
| @@ -4122,6 +4122,23 @@ _PyDictView_New(PyObject *dict, PyTypeObject *type) | |||
| return (PyObject *)dv; | |||
| } | |||
|
|
|||
| static PyObject * | |||
| dictview_mapping(PyObject *view) | |||
There was a problem hiding this comment.
It should have signature compatible with getter:
static PyObject *
dictview_mapping(PyObject *view, void *Py_UNUSED(ignored))
| } | ||
|
|
||
| static PyGetSetDef dictview_getset[] = { | ||
| {"mapping", (getter)dictview_mapping, (setter)NULL, |
There was a problem hiding this comment.
Explicit cast to getter is not needed if fix the signature.
arun-mani-j
pushed a commit
to arun-mani-j/cpython
that referenced
this pull request
Jul 21, 2020
jab
added a commit
to jab/cpython
that referenced
this pull request
Oct 11, 2021
As of bpo-40890 / pythongh-20749.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40890