bpo-40893: Add TkDND support to tkinter #20896
Open
+1,020
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E-Paine
commented
Jun 15, 2020
The `return` command is now used to get the binding returns to TkDND rather than the `set` command (for details on `-level 0` see https://www.tcl.tk/man/tcl8.6/TclCmd/return.htm#M18)
Added a few tests for the new bindings
Removed an import introduced early in development (which I forgot to remove)
|
I don't think I have forgotten anything, so am marking this ready for review (apologies about the messy commit history) |
sumeshir26
approved these changes
Feb 15, 2022
|
@sumeshir26 Please do not make drive-by approvals without any comment. You are welcome to really review pull requests, but that requires some effort. Otherwise, your activity is annoying for the team and does not add anything of value to your profile. |
|
Any progress on the new DND integration? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40893