Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41009: fix requires_OS_version() class decorator #20942

Merged
merged 2 commits into from Jun 17, 2020
Merged

bpo-41009: fix requires_OS_version() class decorator #20942

merged 2 commits into from Jun 17, 2020

Conversation

tiran
Copy link
Member

@tiran tiran commented Jun 17, 2020 •
edited by miss-islington

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue41009

Automerge-Triggered-By: @tiran

@tiran tiran added tests Tests in the Lib/test dir needs backport to 3.7 needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes labels Jun 17, 2020
@tiran tiran requested a review from vstinner June 17, 2020 15:28
@tiran
bpo-41009: fix requires_OS_version() class decorator
358d98d 
Signed-off-by: Christian Heimes <christian@python.org>
@tiran
Address code review
de2d8d8 
Signed-off-by: Christian Heimes <christian@python.org>
vstinner
vstinner approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miss-islington miss-islington merged commit bb6ec14 into python:master Jun 17, 2020
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @tiran, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker bb6ec14479f18c32e71e43f2785f177aa17aabbd 3.9

@miss-islington miss-islington self-assigned this Jun 17, 2020
@miss-islington
Copy link
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker bb6ec14479f18c32e71e43f2785f177aa17aabbd 3.8

@miss-islington
Copy link
Contributor

Sorry @tiran, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker bb6ec14479f18c32e71e43f2785f177aa17aabbd 3.7

@tiran tiran added needs backport to 3.9 only security fixes and removed needs backport to 3.7 needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes labels Jun 17, 2020
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker bb6ec14479f18c32e71e43f2785f177aa17aabbd 3.9

tiran added a commit to tiran/cpython that referenced this pull request Jun 17, 2020
@tiran
[3.9] bpo-41009: fix requires_OS_version() class decorator (pythonGH-…
272a7c1 
…20942)

Signed-off-by: Christian Heimes <christian@python.org>

Automerge-Triggered-By: @tiran.
(cherry picked from commit bb6ec14)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jun 17, 2020
@bedevere-bot
Copy link

GH-20947 is a backport of this pull request to the 3.9 branch.

tiran added a commit to tiran/cpython that referenced this pull request Jun 17, 2020
@tiran
[3.8] bpo-41009: fix requires_OS_version() class decorator (pythonGH-…
84d3f71 
…20942)

Signed-off-by: Christian Heimes <christian@python.org>

Automerge-Triggered-By: @tiran.
(cherry picked from commit bb6ec14)

Co-authored-by: Christian Heimes <christian@python.org>
tiran added a commit to tiran/cpython that referenced this pull request Jun 17, 2020
@tiran
[3.7] bpo-41009: fix requires_OS_version() class decorator (pythonGH-…
15c6796 
…20942)

Signed-off-by: Christian Heimes <christian@python.org>

Automerge-Triggered-By: @tiran.
(cherry picked from commit bb6ec14)

Co-authored-by: Christian Heimes <christian@python.org>
ned-deily pushed a commit that referenced this pull request Jun 25, 2020
@tiran
[3.7] bpo-41009: fix requires_OS_version() class decorator (GH-20942) (…
d3798ed 
…GH-20949)

Signed-off-by: Christian Heimes <christian@python.org>

Automerge-Triggered-By: @tiran.
(cherry picked from commit bb6ec14)

Co-authored-by: Christian Heimes <christian@python.org>
miss-islington pushed a commit that referenced this pull request Jun 25, 2020
@tiran
[3.9] bpo-41009: fix requires_OS_version() class decorator (GH-20942) (…
cd6f911 
…GH-20947)

Signed-off-by: Christian Heimes <christian@python.org>

Automerge-Triggered-By: @tiran.
(cherry picked from commit bb6ec14)

Co-authored-by: Christian Heimes <christian@python.org>
miss-islington pushed a commit that referenced this pull request Jun 25, 2020
@tiran
[3.8] bpo-41009: fix requires_OS_version() class decorator (GH-20942) (…
8075fe1 
…GH-20948)

Signed-off-by: Christian Heimes <christian@python.org>

Automerge-Triggered-By: @tiran.
(cherry picked from commit bb6ec14)

Co-authored-by: Christian Heimes <christian@python.org>
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@tiran @arun-mani-j
bpo-41009: fix requires_OS_version() class decorator (pythonGH-20942)
55bec89 
Signed-off-by: Christian Heimes <christian@python.org>

Automerge-Triggered-By: @tiran
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

@miss-islington miss-islington

Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tiran @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni