New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-40939: Remove the old parser (Part 2) #21005
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG assuming the tests pass.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I have made the requested changes; please review again |
Thanks for making the requested changes! @gvanrossum, @pablogsal: please review the changes made to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lysnikolaou I was going to start a PR for re-implementing/re-naming the parser functions but maybe you have already started one? :) |
I was just about to, but you can do it if you think reviewing my PR is going to take more time. Whatever you want! |
Go ahead if you have time now, as I will only be able to do one in a couple of hours |
Agreed that the public APIs that don't depend on types like |
Remove some remaining files and Makefile targets for the old parser
Remove some remaining files and Makefile targets for the old parser
https://bugs.python.org/issue40939