Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41065: Use zip-strict in zoneinfo #21031

Merged
merged 1 commit into from Jun 23, 2020

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Jun 21, 2020

Can someone please put the skip-news tag here?

Thanks @alexmojaki for writing the script with which I found this instance.

https://bugs.python.org/issue41065

@pganssle
Copy link
Member

Nice.

I'm going to go ahead and merge this, but I'm slightly concerned that this is the first divergence between the 3.9 and master branches, since this can't be backported to 3.9. If it starts to consistently make backports more difficult, I think we should temporarily revert it and replace it with a #TODO to use strict=True once the code base has fully stabilized (since it's a mostly cosmetic change anyway).

@pganssle pganssle merged commit bc43f6e into python:master Jun 23, 2020
@cool-RR
Copy link
Contributor Author

cool-RR commented Jun 23, 2020

Okay. If you'll remember to tag me when that happens, that'll be nice. Thanks for merging.

fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@cool-RR cool-RR mannequin mentioned this pull request Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants