bpo-32751: Wait for task cancel in asyncio.wait_for() when timeout <= 0 #21895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I was fixing bpo-32751 back in pythonGH-7216 I missed the case when *timeout* is zero or negative. This takes care of that. Props to @aaliddell for noticing the inconsistency.
1st1
approved these changes
Aug 18, 2020
1st1
added
needs backport to 3.7
needs backport to 3.8
|
closing/reopening to hopefully fix travis |
|
@1st1: Please replace |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 26, 2020
… 0 (pythonGH-21895) When I was fixing bpo-32751 back in pythonGH-7216 I missed the case when *timeout* is zero or negative. This takes care of that. Props to @aaliddell for noticing the inconsistency. (cherry picked from commit c517fc7) Co-authored-by: Elvis Pranskevichus <elvis@magic.io>
|
GH-21963 is a backport of this pull request to the 3.9 branch. |
|
Sorry, @elprans and @1st1, I could not cleanly backport this to |
|
Sorry @elprans and @1st1, I had trouble checking out the |
|
GH-21967 is a backport of this pull request to the 3.8 branch. |
|
GH-21968 is a backport of this pull request to the 3.7 branch. |
elprans
added a commit
to elprans/cpython
that referenced
this pull request
Aug 26, 2020
…out <= 0 (pythonGH-21895) When I was fixing bpo-32751 back in pythonGH-7216 I missed the case when *timeout* is zero or negative. This takes care of that. Props to @aaliddell for noticing the inconsistency.. (cherry picked from commit c517fc7) Co-authored-by: Elvis Pranskevichus <elvis@magic.io>
elprans
added a commit
to elprans/cpython
that referenced
this pull request
Aug 26, 2020
…out <= 0 (pythonGH-21895) When I was fixing bpo-32751 back in pythonGH-7216 I missed the case when *timeout* is zero or negative. This takes care of that. Props to @aaliddell for noticing the inconsistency.. (cherry picked from commit c517fc7)
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
… 0 (python#21895) When I was fixing bpo-32751 back in pythonGH-7216 I missed the case when *timeout* is zero or negative. This takes care of that. Props to @aaliddell for noticing the inconsistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was fixing bpo-32751 back in GH-7216 I missed the case when
timeout is zero or negative. This takes care of that.
Props to @aaliddell for noticing the inconsistency.
https://bugs.python.org/issue32751