bpo-41670: Remove outdated predict macro invocation. #22026
Conversation
| Prevent line trace being skipped on Windows and Mac when a for loop is | ||
| nested within a try-except block. |
There was a problem hiding this comment.
I would mention "Python compiled without USE_COMPUTED_GOTOS" instead because there isn't anything platform-specific AFAIK
There was a problem hiding this comment.
Computed gotos are a GCC specific feature, and is always on the release builds on platforms that use GCC.
We don't use GCC for Windows or Mac.
So it is kinda platform specific.
As far as the user is concerned, it's the platform they are using, not the compiler that we use that's relevant.
There was a problem hiding this comment.
Computed gotos are a GCC specific feature, and is always on the release builds on platforms that use GCC.
computed gotos (the capability) is actually a C language extension supported on many compilers (including gcc, clang, icc...but not the Microsoft compiler). It can perfectly be activated in Mac with clang for instance.
For instance, here is the test suite of clang: https://github.com/llvm-mirror/clang/blob/eba646b53dd71389216e9a36837fa204b934f8de/test/AST/ast-dump-stmt.c#L130
There was a problem hiding this comment.
Also I think we're already using computed gotos on mac according to @nedbat's comment here: nedbat/coveragepy#959 (comment)
markshannon
force-pushed
the
remove-old-predict
branch
from
0c48b5d
to
b041795
Compare
Remove PREDICTion of POP_BLOCK from FOR_ITER.
https://bugs.python.org/issue41670