Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41776: Revise example of "continue" in the tutorial documentation #22234

Merged
merged 3 commits into from Sep 15, 2020
Merged

bpo-41776: Revise example of "continue" in the tutorial documentation #22234

merged 3 commits into from Sep 15, 2020

Conversation

neerajsamtani
Copy link
Contributor

@neerajsamtani neerajsamtani commented Sep 13, 2020 •
edited by bedevere-bot

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@neerajsamtani

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 13, 2020
ericvsmith
ericvsmith requested changes Sep 14, 2020
View reviewed changes
Doc/tutorial/controlflow.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@neerajsamtani
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

ericvsmith
ericvsmith reviewed Sep 14, 2020
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. As soon as the CLA is signed, I'll merge it.

@ericvsmith ericvsmith added needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes labels Sep 14, 2020
@ericvsmith ericvsmith self-assigned this Sep 14, 2020
@neerajsamtani
Copy link
Contributor Author

@ericvsmith notifying you that the CLA has been signed so you can now merge it. Thanks

@ericvsmith ericvsmith merged commit 7bcc645 into python:master Sep 15, 2020
@miss-islington
Copy link
Contributor

Thanks @neerajsamtani for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@ericvsmith
Copy link
Member

Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 15, 2020
@neerajsamtani @miss-islington
bpo-41776: Revise example of "continue" in the tutorial documentation (…
76e0c1e 
…pythonGH-22234)

Revise example of "continue" in the tutorial documentation
(cherry picked from commit 7bcc645)

Co-authored-by: Neeraj Samtani <neerajjsamtani@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Sep 15, 2020
@bedevere-bot
Copy link

GH-22255 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 15, 2020
@neerajsamtani @miss-islington
bpo-41776: Revise example of "continue" in the tutorial documentation (…
58dfdd4 
…pythonGH-22234)

Revise example of "continue" in the tutorial documentation
(cherry picked from commit 7bcc645)

Co-authored-by: Neeraj Samtani <neerajjsamtani@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Sep 15, 2020
@bedevere-bot
Copy link

GH-22256 is a backport of this pull request to the 3.8 branch.

ericvsmith pushed a commit that referenced this pull request Sep 15, 2020
@miss-islington @neerajsamtani
bpo-41776: Revise example of "continue" in the tutorial documentation (…
0cc037f 
…GH-22234) (GH-22255)

Revise example of "continue" in the tutorial documentation
(cherry picked from commit 7bcc645)

Co-authored-by: Neeraj Samtani <neerajjsamtani@gmail.com>

Co-authored-by: Neeraj Samtani <neerajjsamtani@gmail.com>
ericvsmith pushed a commit that referenced this pull request Sep 15, 2020
@miss-islington @neerajsamtani
bpo-41776: Revise example of "continue" in the tutorial documentation (…
a0da907 
…GH-22234) (GH-22256)

Revise example of "continue" in the tutorial documentation
(cherry picked from commit 7bcc645)

Co-authored-by: Neeraj Samtani <neerajjsamtani@gmail.com>

Co-authored-by: Neeraj Samtani <neerajjsamtani@gmail.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@neerajsamtani
bpo-41776: Revise example of "continue" in the tutorial documentation (…
9f809a2 
…pythonGH-22234)

Revise example of "continue" in the tutorial documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith ericvsmith requested changes

Assignees

@ericvsmith ericvsmith

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@neerajsamtani @the-knights-who-say-ni @bedevere-bot @miss-islington @ericvsmith