New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-41891: ensure asyncio.wait_for waits for task completion #22461
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
0ea025f
to
c8a7b00
Compare
@elprans please take a look. You've been fixing wait_for for quite some time. |
The fix looks good to me. Needs a test, though. |
asyncio.wait_for should wait for the future to terminate in all cases.
Thanks @rkojedzinszky for the PR, and @1st1 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
@1st1: Please replace |
GH-23840 is a backport of this pull request to the 3.9 branch. |
GH-23841 is a backport of this pull request to the 3.8 branch. |
https://bugs.python.org/issue41891