Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41490: Bump vendored pip to version 20.2.3 #22527

Merged
merged 1 commit into from Oct 4, 2020
Merged

bpo-41490: Bump vendored pip to version 20.2.3 #22527

merged 1 commit into from Oct 4, 2020

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Oct 3, 2020 •
edited by miss-islington

@pablogsal pablogsal added needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes labels Oct 3, 2020
@pablogsal pablogsal requested review from zooba and ambv October 3, 2020 19:09
@pablogsal
Copy link
Member Author

@ambv Would it be possible to include this in the 3.9 release to avoid the pip bug in venvs?

@pablogsal
Copy link
Member Author

CC: @pradyunsg

@pablogsal
Copy link
Member Author

I don't understand what is wrong with the Windows tests :(

@pablogsal pablogsal requested a review from vsajip as a code owner October 3, 2020 19:41
@pablogsal pablogsal force-pushed the bpo-414490 branch 4 times, most recently from a92bd36 to 6f724fe Compare October 3, 2020 21:08
@pablogsal
Copy link
Member Author

Something is going on with the pip wheel on Windows that I cannot figure out, @zooba, @pradyunsg, any idea of what may be going on?

@pablogsal
Copy link
Member Author

This is so weird, the moment I use any version for the wheel ">=20.2.0" the error happens :(

@pablogsal
Copy link
Member Author

pablogsal commented Oct 3, 2020 •
edited

Seems that pip>=20.2.0 is holding onto the handler of the wheel file and windows cannot clean the temporary directory after

@pradyunsg
Copy link
Member

/cc @pfmoore @uranusjr as pip devs who use Windows.

@pablogsal
Copy link
Member Author

pablogsal commented Oct 3, 2020 •
edited

I can workaround pip leaking handles onto the wheels by executing the bootstrapping in a subprocess, which may have the advantage of simplifying the code a bit.

@ambv ambv merged commit 2cc6dc9 into python:master Oct 4, 2020
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Sorry, @pablogsal and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2cc6dc9896771ef3615abbb5ba80939a2f644a08 3.9

@miss-islington
Copy link
Contributor

Sorry @pablogsal and @ambv, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 2cc6dc9896771ef3615abbb5ba80939a2f644a08 3.8

pablogsal added a commit to pablogsal/cpython that referenced this pull request Oct 4, 2020
@pablogsal
[3.9] bpo-41490: Bump vendored pip to version 20.2.3 (pythonGH-22527).
5ae68a4 
(cherry picked from commit 2cc6dc9)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot
Copy link

GH-22544 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed needs backport to 3.9 only security fixes needs backport to 3.8 only security fixes labels Oct 4, 2020
@bedevere-bot
Copy link

GH-22545 is a backport of this pull request to the 3.8 branch.

pablogsal added a commit to pablogsal/cpython that referenced this pull request Oct 4, 2020
@pablogsal
[3.8] bpo-41490: Bump vendored pip to version 20.2.3 (pythonGH-22527).
70fa499 
(cherry picked from commit 2cc6dc9)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@pablogsal pablogsal mentioned this pull request Oct 4, 2020
Closed
@pablogsal pablogsal deleted the bpo-414490 branch October 4, 2020 17:10
ambv pushed a commit that referenced this pull request Oct 4, 2020
@pablogsal
[3.9] bpo-41490: Bump vendored pip to version 20.2.3 (GH-22527). (GH-…
4b4d60f 
…22544)

(cherry picked from commit 2cc6dc9)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
ambv pushed a commit that referenced this pull request Oct 4, 2020
@pablogsal
[3.8] bpo-41490: Bump vendored pip to version 20.2.3 (GH-22527). (GH-…
28cd96f 
…22545)

(cherry picked from commit 2cc6dc9)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@python python deleted a comment from bedevere-bot Oct 4, 2020
ambv pushed a commit to ambv/cpython that referenced this pull request Oct 4, 2020
@pablogsal @ambv
[3.9] bpo-41490: Bump vendored pip to version 20.2.3 (pythonGH-22527). (
168a838 
pythonGH-22544)

(cherry picked from commit 2cc6dc9)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@pablogsal
bpo-41490: Bump vendored pip to version 20.2.3 (python#22527)
fad5892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba Awaiting requested review from zooba

@ambv ambv Awaiting requested review from ambv

@vsajip vsajip Awaiting requested review from vsajip

Assignees

@ambv ambv

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pablogsal @pradyunsg @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni