[3.5] bpo-30687: Fixes build scripts to find msbuild.exe and stop relying on vcvarsall.bat #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n vcvarsall.bat (python#2252) * Fixes build scripts to find msbuild.exe and stop relying on vcvarsall.bat Also fixes bdist_wininst.vcxproj to use correct version in generated name.
zooba
commented
Jun 19, 2017
| @@ -57,6 +57,7 @@ if "%1" EQU "--build" (set TARGET=Build) && shift && goto CheckOpts | |||
| if "%1" EQU "-x86" (set BUILDX86=1) && shift && goto CheckOpts | |||
| if "%1" EQU "-x64" (set BUILDX64=1) && shift && goto CheckOpts | |||
| if "%1" EQU "--pgo" (set PGO=%~2) && shift && shift && goto CheckOpts | |||
| if "%1" EQU "--skip-pgo" (set PGO=) && shift && goto CheckOpts | |||
There was a problem hiding this comment.
Should be noted that --skip-pgo is still the default for 3.5 (see the set PGO= higher up in this file).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n vcvarsall.bat (#2252)
Also fixes bdist_wininst.vcxproj to use correct version in generated name.