Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] bpo-41659: Disallow curly brace directly after primary (GH-22996) #23006

Merged
merged 1 commit into from Oct 27, 2020

Conversation

lysnikolaou
Copy link
Contributor

@lysnikolaou lysnikolaou commented Oct 27, 2020

(cherry picked from commit 15acc4e)

https://bugs.python.org/issue41659

@lysnikolaou
Copy link
Contributor Author

I opened this PR without having made up my mind if we really should merge it or not. Having a left-recursive rule, that's called so frequently, open with an invalid alternative seems like it will have some performance implications. Should we maybe revisit backporting #22111 to 3.9 before merging this one?

CC @pablogsal @gvanrossum

@pablogsal
Copy link
Member

I opened this PR without having made up my mind if we really should merge it or not. Having a left-recursive rule, that's called so frequently, open with an invalid alternative seems like it will have some performance implications. Should we maybe revisit backporting #22111 to 3.9 before merging this one?

CC @pablogsal @gvanrossum

I would say that is wise to have an idea of the impact of this before doing anything, definitely.

@lysnikolaou
Copy link
Contributor Author

The stdlib benchmark went from 7.530s (mean from running it 4 times) in the 3.9 branch to 7.546s here.

@bedevere-bot
Copy link

@lysnikolaou: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants