bpo-38647: Add *name* to webbrowser.MacOSXOSAScript #23134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds some tests for this class.
ronaldoussoren
added
OS-mac
needs backport to 3.8
|
I've converted the PR to a draf because I'm not happy with the patch. |
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today. |
github-actions
bot
removed
the
stale
|
This is a trivial PR with a merge conflict. I'll a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a name attribute to webbrowser.MacOSXOSAScript and add some tests for the class.
The PR keeps the _name attribute for backward compatibility, even if the attribute is (like name) not documented.
https://bugs.python.org/issue38647