Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42345: Add whatsnew for typing.Literal in 3.10 #23385

Merged
merged 7 commits into from Nov 19, 2020

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Nov 19, 2020

I noticed that there were 4 changes in behavior rather than 3.

This is PR 1 of 2. A second PR is needed for 3.9 and backporting.

https://bugs.python.org/issue42345

Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
@gvanrossum gvanrossum merged commit 4687338 into python:master Nov 19, 2020
@Fidget-Spinner Fidget-Spinner deleted the whatsnew-42345 branch November 19, 2020 04:50
@uriyyo
Copy link
Member

uriyyo commented Nov 19, 2020

@Fidget-Spinner I thought that I will update whatsnew but then found this PR. Thanks, for updating docs)

@Fidget-Spinner
Copy link
Member Author

@Fidget-Spinner I thought that I will update whatsnew but then found this PR. Thanks, for updating docs)

Np, and my bad if you were already working on it halfway. Thought you were gonna be busy with function annotations and Literal hashes so I decided to help out instead.

@uriyyo
Copy link
Member

uriyyo commented Nov 19, 2020

Your description of Literal whatsnew is awesome. I believe I will spend several hours to write something like you did. Thank you very much🙂

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants