bpo-10486 - Remove the conditional for setting query. #23604
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://bugs.python.org/issue10486, there was a discussion about setting all the environment variables in CGI. I am not certain if we need that, I plan to recommend closing the issue without any changes, since the request is stale, and CGI specification leaves it to implementation. Two of the commenters in that issue agree
There is a minor change that is not related to the issue but was observed in the discussion.
QUERY_STRING is always set in the env
However, earlier in the code, it was being tested for a non-empty value. This test condition was not required. Instead of leaving that no-op test condition, I am removing it in this PR. Since this is not a bug fix, but a cosmetic improvement, I don't think we need to backport.
https://bugs.python.org/issue10486