bpo-32381: Rewrite PyErr_ProgramText() #23700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyErr_ProgramText() now calls PyErr_ProgramTextObject().
izbyshev
reviewed
Dec 8, 2020
|
|
||
| PyObject *filename_obj = PyUnicode_DecodeFSDefault(filename); | ||
| if (filename_obj == NULL) { | ||
| return NULL; |
There was a problem hiding this comment.
Are you sure that the contract of this function allows raising an exception? It seems that PyErr_ProgramTextObject takes care to clear the exception, as does err_programtext.
There was a problem hiding this comment.
I don't know. In case of doubt, I added a PyErr_Clear() call.
My first intent was to deprecate the function. IMO it was exposed by mistake in the stable ABI. But since PyErr_ProgramTextObject() is still needed, I prefer to rewrite PyErr_ProgramText() with PyErr_ProgramTextObject().
There was a problem hiding this comment.
Thanks. Better safe than sorry :)
|
Thanks for the review @izbyshev. |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
PyErr_ProgramText() now calls PyErr_ProgramTextObject().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyErr_ProgramText() now calls PyErr_ProgramTextObject().
https://bugs.python.org/issue32381