New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-42734: Fix crasher bogus_code_obj.py #23939
Merged
serhiy-storchaka
merged 1 commit into
python:master
from
serhiy-storchaka:bogus_code_obj
Dec 25, 2020
Merged
bpo-42734: Fix crasher bogus_code_obj.py #23939
serhiy-storchaka
merged 1 commit into
python:master
from
serhiy-storchaka:bogus_code_obj
Dec 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It did not work because the signature of code object constructor was changed. Also, it used old format of bytecode (pre-wordcode).
serhiy-storchaka
added
tests
Tests in the Lib/test dir
skip news
needs backport to 3.8
only security fixes
needs backport to 3.9
only security fixes
labels
Dec 25, 2020
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 25, 2020
It did not work because the signature of code object constructor was changed. Also, it used old format of bytecode (pre-wordcode). (cherry picked from commit 954a742) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-23940 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 25, 2020
It did not work because the signature of code object constructor was changed. Also, it used old format of bytecode (pre-wordcode). (cherry picked from commit 954a742) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-23941 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Dec 25, 2020
miss-islington
added a commit
that referenced
this pull request
Dec 25, 2020
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
It did not work because the signature of code object constructor was changed. Also, it used old format of bytecode (pre-wordcode).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It did not work because the signature of code object constructor
was changed. Also, it used old format of bytecode (pre-wordcode).
https://bugs.python.org/issue42734