Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42952: Fix the handling of EC_KEY_new_by_curve_name() in _ssl.c #24237

Closed
wants to merge 1 commit into from
Closed

bpo-42952: Fix the handling of EC_KEY_new_by_curve_name() in _ssl.c #24237

wants to merge 1 commit into from

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Jan 18, 2021 •
edited by bedevere-bot

@ZackerySpytz
Copy link
Contributor Author

This is a "skip news" PR.

serhiy-storchaka
serhiy-storchaka approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. BTW there is a similar code in _ssl__SSLContext_set_ecdh_curve().

@serhiy-storchaka serhiy-storchaka added needs backport to 3.9 only security fixes type-bug An unexpected behavior, bug, or error needs backport to 3.8 only security fixes labels Jan 18, 2021
tiran
tiran requested changes Jan 18, 2021
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's dead code and never used with supported OpenSSL versions.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@serhiy-storchaka
Copy link
Member

If it is never used, then why not remove it?

If it still can be used on some platforms, it is worth to fix it. The existence of similar code in other place adds confidence in the correctness of the proposed change (it also conforms the documentation).

@tiran
Copy link
Member

tiran commented Jan 18, 2021

As I explained in the ticket I will remove all unused code in one PR in the future.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 18, 2021
@tiran
Copy link
Member

tiran commented Apr 17, 2021

Code is gone.

@tiran tiran closed this Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran tiran requested changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
awaiting changes needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes stale Stale PR or inactive for long period of time. type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ZackerySpytz @bedevere-bot @serhiy-storchaka @tiran @the-knights-who-say-ni