Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-43016: Rewrite tests for curses #24312

Merged
merged 4 commits into from Jan 31, 2021

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 24, 2021

@serhiy-storchaka serhiy-storchaka merged commit d64fd4b into python:master Jan 31, 2021
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d64fd4bb5bb4fd2e3277f39d3ad99b5a8d193e1b 3.9

@miss-islington
Copy link
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker d64fd4bb5bb4fd2e3277f39d3ad99b5a8d193e1b 3.8

@bedevere-bot
Copy link

GH-24399 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jan 31, 2021
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jan 31, 2021
(cherry picked from commit d64fd4b)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka deleted the test-curses branch January 31, 2021 15:43
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.x has failed when building commit d64fd4b.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/506/builds/765) and take a look at the build logs.
  4. Check if the failure is related to this commit (d64fd4b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/506/builds/765

Failed tests:

  • test_curses

Failed subtests:

  • test_output_character - test.test_curses.TestCurses
  • test_background - test.test_curses.TestCurses

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

408 tests OK.

10 slowest tests:

  • test_concurrent_futures: 5 min 3 sec
  • test_unparse: 3 min 18 sec
  • test_gdb: 3 min 7 sec
  • test_multiprocessing_spawn: 3 min 3 sec
  • test_capi: 2 min 40 sec
  • test_tokenize: 2 min 38 sec
  • test_peg_generator: 2 min 26 sec
  • test_lib2to3: 2 min 15 sec
  • test_unicodedata: 1 min 53 sec
  • test_asyncio: 1 min 47 sec

1 test failed:
test_curses

17 tests skipped:
test_devpoll test_idle test_ioctl test_kqueue test_msilib
test_ossaudiodev test_startfile test_tcl test_tix test_tk
test_ttk_guionly test_ttk_textonly test_turtle test_winconsoleio
test_winreg test_winsound test_zipfile64

1 re-run test:
test_curses

Total duration: 29 min 20 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_curses.py", line 474, in test_background
    self.assertEqual(win.getbkgd(), 0)
AssertionError: 32 != 0


Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_curses.py", line 249, in test_output_character
    stdscr.addch('\u20ac')
OverflowError: byte doesn't fit in chtype

serhiy-storchaka added a commit that referenced this pull request Jan 31, 2021
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jan 31, 2021
…thonGH-24399)

(cherry picked from commit d64fd4b).
(cherry picked from commit e9d4960)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Jan 31, 2021
…24401)

(cherry picked from commit d64fd4b).
(cherry picked from commit e9d4960)
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.8 has failed when building commit 7ca947e.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/360/builds/192) and take a look at the build logs.
  4. Check if the failure is related to this commit (7ca947e) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/360/builds/192

Failed tests:

  • test_curses

Failed subtests:

  • test_output_character - test.test_curses.TestCurses
  • test_background - test.test_curses.TestCurses

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

405 tests OK.

10 slowest tests:

  • test_concurrent_futures: 3 min 47 sec
  • test_multiprocessing_spawn: 3 min 28 sec
  • test_tokenize: 2 min 42 sec
  • test_gdb: 2 min 8 sec
  • test_tools: 1 min 49 sec
  • test_multiprocessing_forkserver: 1 min 43 sec
  • test_lib2to3: 1 min 35 sec
  • test_multiprocessing_fork: 1 min 29 sec
  • test_asyncio: 1 min 27 sec
  • test_capi: 1 min

1 test failed:
test_curses

17 tests skipped:
test_devpoll test_idle test_ioctl test_kqueue test_msilib
test_ossaudiodev test_startfile test_tcl test_tix test_tk
test_ttk_guionly test_ttk_textonly test_turtle test_winconsoleio
test_winreg test_winsound test_zipfile64

1 re-run test:
test_curses

Total duration: 23 min 7 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.8.bolen-ubuntu/build/Lib/test/test_curses.py", line 473, in test_background
    self.assertEqual(win.getbkgd(), 0)
AssertionError: 32 != 0


Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.8.bolen-ubuntu/build/Lib/test/test_curses.py", line 248, in test_output_character
    stdscr.addch('\u20ac')
OverflowError: byte doesn't fit in chtype

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs backport to 3.8 only security fixes skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants