Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-30742 Enabling compiling with VS2015 #2446

Closed
wants to merge 1 commit into from
Closed

bpo-30742 Enabling compiling with VS2015 #2446

wants to merge 1 commit into from

Conversation

dzenanz
Copy link

@dzenanz dzenanz commented Jun 27, 2017

No description provided.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@dzenanz dzenanz mentioned this pull request Jun 27, 2017
Closed
zooba
zooba requested changes Jun 27, 2017
View reviewed changes
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are insufficient to make Python work properly when built with MSVC 14.0 or later. I've rejected the bug on BPO - please continue the discussion there if you feel strongly about this.

@jcfr
Copy link

jcfr commented Jul 1, 2017

@zooba Thanks for the feedback.

These changes are insufficient to make Python work properly when built with MSVC 14.0 or later.

Would you have some additional hints allowing to implement a proper patch ?

@zooba
Copy link
Member

zooba commented Jul 3, 2017

Find the issue on bugs.python.org for the port I made for Python 3.5 and see the associated patches.

@terryjreedy
Copy link
Member

Issue has been closed rejecting the patch for cpython

@jcfr
Copy link

jcfr commented Aug 1, 2017

For future reference, here are the related python 3.5 issues mentioned in @zooba review :

and some of the related patches I could find:

For future reference, to allow building of Python 2.7.13 using VS2015:

terryjreedy added a commit that referenced this pull request Feb 7, 2021
@terryjreedy
bpo-16781: In 'exec' doc, add 'nonlocal' to 'yield' and 'return' (GH-…
0ec57e2 
…2446)

These 3 statements cannot be used at module scope -- nor in exec with one namespace.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 7, 2021
@terryjreedy @miss-islington
bpo-16781: In 'exec' doc, add 'nonlocal' to 'yield' and 'return' (pyt…
dcb4ff5 
…honGH-2446)

These 3 statements cannot be used at module scope -- nor in exec with one namespace.
(cherry picked from commit 0ec57e2)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 7, 2021
@terryjreedy @miss-islington
bpo-16781: In 'exec' doc, add 'nonlocal' to 'yield' and 'return' (pyt…
27ce1b1 
…honGH-2446)

These 3 statements cannot be used at module scope -- nor in exec with one namespace.
(cherry picked from commit 0ec57e2)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull request Feb 7, 2021
@miss-islington @terryjreedy
bpo-16781: In 'exec' doc, add 'nonlocal' to 'yield' and 'return' (GH-…
920bf6a 
…2446)

These 3 statements cannot be used at module scope -- nor in exec with one namespace.
(cherry picked from commit 0ec57e2)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy added a commit that referenced this pull request Feb 7, 2021
@miss-islington @terryjreedy
bpo-16781: In 'exec' doc, add 'nonlocal' to 'yield' and 'return' (GH-…
863eb71 
…2446)

These 3 statements cannot be used at module scope -- nor in exec with one namespace.
(cherry picked from commit 0ec57e2)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@terryjreedy
Copy link
Member

The references from me are actually from the miss-islinton bot. They are an accident because when copying the current title line when merging PR 24469, I omitted the 9, so when miss-islington was processing the backports, it had the wrong original number.

@jcfr
Copy link

jcfr commented Feb 8, 2021

@terryjreedy Makes sense. Thanks for the clarification.

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@terryjreedy @adorilson
bpo-16781: In 'exec' doc, add 'nonlocal' to 'yield' and 'return' (pyt…
9f16613 
…honGH-2446)

These 3 statements cannot be used at module scope -- nor in exec with one namespace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dzenanz @the-knights-who-say-ni @jcfr @zooba @terryjreedy