Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] bpo-30769: Fix reference leak introduced in 7770394 (GH-2416) #2447

Merged
merged 1 commit into from Jun 27, 2017
Merged

[3.5] bpo-30769: Fix reference leak introduced in 7770394 (GH-2416) #2447

merged 1 commit into from Jun 27, 2017

Conversation

emilyemorehouse
Copy link
Member

No description provided.

@bedevere-bot bedevere-bot mentioned this pull request Jun 27, 2017
Merged
@emilyemorehouse
Copy link
Member Author

@Haypo A clean rebase allowed me to duplicate the original error on 3.5. I've confirmed that this now passes with the fix.

vstinner
vstinner approved these changes Jun 27, 2017
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that "./python -m test -R 3:3 -m test_execve_invalid_env test_os" fails without the fix, and pass with the fix, thanks!

@vstinner vstinner merged commit eb3c52a into python:3.5 Jun 27, 2017
@vstinner
Copy link
Member

Thanks @emilyemorehouse for the fix ;-) I merged your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emilyemorehouse @vstinner @the-knights-who-say-ni