Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-43200: Fix a link to shutil.copy() in the shutil module docs #24505

Merged
merged 2 commits into from Feb 13, 2021

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Feb 11, 2021

A link generated for the copy() function was linking to the copy
module. It should link to the shutil.copy() function instead.

Use reST markup to ensure the other functions in the sentence also
link to shutil functions.

https://bugs.python.org/issue43200

A link generated for the copy() function was linking to the copy
module.  It should link to the shutil.copy() function instead.

Use reST markup to ensure the other functions in the sentence also
link to shutil functions.
Copy link
Contributor

@serverwentdown serverwentdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With only a couple of exception, this doc only uses '~shutil' when needed, for 'copy', so I removed the ones not needed. I check and there are no other instances "copy" to fix in this file.

@terryjreedy terryjreedy merged commit 762fe7d into python:master Feb 13, 2021
@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 13, 2021
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 762fe7d)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

GH-24523 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Feb 13, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 13, 2021
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 762fe7d)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Feb 13, 2021
@bedevere-bot
Copy link

GH-24524 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Feb 13, 2021
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 762fe7d)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
terryjreedy pushed a commit that referenced this pull request Feb 13, 2021
Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 762fe7d)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants